-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nfcore intermediate training #448
Nfcore intermediate training #448
Conversation
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Jonathan Manning <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more minor things, think this works well for now.
Possibly, after next week's training, rather than fairly disjointed examples, we can start to apply a bit more more narrative to this. So, "we want to build a pipeline to do x, here's how we do that using nf-core tooling and resources"
Co-authored-by: Jonathan Manning <[email protected]>
Co-authored-by: Jonathan Manning <[email protected]>
Co-authored-by: Jonathan Manning <[email protected]>
Co-authored-by: Jonathan Manning <[email protected]>
Co-authored-by: Jonathan Manning <[email protected]>
Co-authored-by: Jonathan Manning <[email protected]>
Co-authored-by: Jonathan Manning <[email protected]>
Co-authored-by: Jonathan Manning <[email protected]>
Co-authored-by: Jonathan Manning <[email protected]>
Co-authored-by: Jonathan Manning <[email protected]>
Co-authored-by: Jonathan Manning <[email protected]>
Co-authored-by: Jonathan Manning <[email protected]>
agreed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor language suggestions and typos. Please double check the commands haven't changed. E.g., nextflow pipelines schema build
not nextflow schema build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a bunch of minor comments. Most of the are language suggestions. I don't see any major blockers so I've approved.
Co-authored-by: Christopher Hakkaart <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this module! I'd say it's a little long, but I don't feel like time is our biggest concern and it's a great introduction to nf-core.
Most of my comments are just refinements on the language or examples which could be updated, nothing too serious.
Co-authored-by: Adam Talbot <[email protected]>
This training covers:
This training does not cover:
-profile test
), etc.