Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nfcore intermediate training #448

Merged
merged 50 commits into from
Nov 20, 2024

Conversation

FriederikeHanssen
Copy link
Collaborator

This training covers:

  • how to create a pipeline with a stripped down template version
  • how to add an existing nf-core module
  • a brief explanation of meta maps and how to add new fields from the samplesheet
  • how to create a custom module and add it in

This training does not cover:

  • Igenomes
  • Install and use subworkflows
  • How to update components
  • Anything related to GitHub actions, CI/CD, (nf-test) testing (aside from -profile test), etc.
  • Devcontainers (gitPod, Codespaces)
  • How to add more files to MultiQC
  • Mulled containers / Seqera containers
  • Different resource labels
  • Linting
  • Bigger samplesheet adaptations
  • Elaborate meta map access with closures, i.e. in the modules.config
  • Stub tests
  • All ext. fields in the modules.config
  • Git branches
  • How to create your own test profile or where it is stored
  • Patching of modules

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit edbee15
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-training/deploys/673dc62e8b5bf1000826977c
😎 Deploy Preview https://deploy-preview-448--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FriederikeHanssen FriederikeHanssen marked this pull request as ready for review November 14, 2024 16:16
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor things, think this works well for now.

Possibly, after next week's training, rather than fairly disjointed examples, we can start to apply a bit more more narrative to this. So, "we want to build a pipeline to do x, here's how we do that using nf-core tooling and resources"

docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
@FriederikeHanssen
Copy link
Collaborator Author

Possibly, after next week's training, rather than fairly disjointed examples, we can start to apply a bit more more narrative to this. So, "we want to build a pipeline to do x, here's how we do that using nf-core tooling and resources"

agreed!

Copy link
Collaborator

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor language suggestions and typos. Please double check the commands haven't changed. E.g., nextflow pipelines schema build not nextflow schema build

docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a bunch of minor comments. Most of the are language suggestions. I don't see any major blockers so I've approved.

docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
Co-authored-by: Christopher Hakkaart <[email protected]>
adamrtalbot
adamrtalbot previously approved these changes Nov 19, 2024
Copy link
Collaborator

@adamrtalbot adamrtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this module! I'd say it's a little long, but I don't feel like time is our biggest concern and it's a great introduction to nf-core.

Most of my comments are just refinements on the language or examples which could be updated, nothing too serious.

docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Show resolved Hide resolved
docs/hello_nextflow/09_hello_nf-core.md Outdated Show resolved Hide resolved
@adamrtalbot adamrtalbot merged commit 844e9e1 into nextflow-io:master Nov 20, 2024
7 checks passed
@FriederikeHanssen FriederikeHanssen deleted the nfcore_intermediate branch November 21, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants