-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small improvements to add additional context/explanations #461
Small improvements to add additional context/explanations #461
Conversation
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it's an improvement, but the ending worries me a bit. They will be converted into channels implicitly so I think there should be a better way to express the last mention of channels in the new version. What do you think?
Yeah, I'm with @mribeirodantas on this one. I actually don't like the bare I'd rather we encouraged explicit channel creation, because I think it's easier to read. |
I see your points. I believe that there’s room to provide more context for newer developers about when and why to use the "While main data inputs are streamed dynamically through channels, there are two approaches for handling accessory files. The recommended approach is to create explicit channels, which makes data flow clearer and more consistent. Alternatively, the This way, we emphasize explicit channel creation as the best practice while still introducing |
That's an improvement! I keep wanting to throw in the queue/value channel concepts but for very beginners, I think they get more in the way than help 😆. What about a shorter but direct version, like:
|
What happened was:
In the future, value channels will be deprecated and |
TIL. What about single-value non-file channels? |
What about them? names = Channel.of('adam', 'jon', 'marcel')
greeting = "hello"
GREETING(greeting, names) |
Co-authored-by: Adam Talbot <[email protected]>
Optional enhancement: Added additional context to the body and notes to provide clearer explanations around concepts such as tuples and the handling of accessory files.