Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quoting and undercore unused variables #724

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

dialvarezs
Copy link
Contributor

@dialvarezs dialvarezs commented Dec 5, 2024

When I was looking at the code, I noticed some incorrectly placed quotes and corrected them. Additionally, I prefixed unused variables in this file with _ to suppress warnings reported by the language server.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one I can do from my phone :D

LGTM and definitely good to start doing the clean up of the code to make linting happy.

I was actually wondering if just before release we do one last PR (which I want to cut when your other big PR is in), of just fixes to make the language server and nf-core linting happy (we have a lot of warnings, particularly in the local modules). Do you think that would be worth it?

But for now this can be merged once you've added yourself to the contributors list on the README!

subworkflows/local/utils_nfcore_mag_pipeline/main.nf Outdated Show resolved Hide resolved
@dialvarezs
Copy link
Contributor Author

I was actually wondering if just before release we do one last PR (which I want to cut when your other big PR is in), of just fixes to make the language server and nf-core linting happy (we have a lot of warnings, particularly in the local modules). Do you think that would be worth it?

Sure, I don't like seeing red things in the editor hahaha. I can give it a shot.

@dialvarezs dialvarezs merged commit 62d6f3d into nf-core:dev Dec 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants