-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Trimmomatic, support contig for bining, set concoct default parameters #745
base: dev
Are you sure you want to change the base?
Added Trimmomatic, support contig for bining, set concoct default parameters #745
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to make the use of scaffolds/contigs for binning a param rather than a replacement
Included Trimmomatic
Added clip tool as trimmmomatic. removed skip_concoct=true
added ext.args ='c 10000 -o 0 --merge_last at 642
57f463f
to
b1eb9ed
Compare
I have added a new parameter |
closes #744 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now....lets get a review from #mag ppl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please add running trimmomatic to one of the test configs so we know it can execute at least once
And generally missing docs!
- Listing in the README
- Missing output.md
Otherwise code looks good! Just some consistency things
@@ -59,6 +59,7 @@ params { | |||
// assembly options | |||
coassemble_group = false | |||
spades_options = null | |||
spades_use_contigs_not_scaffolds = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spades_use_contigs_not_scaffolds = false | |
spades_use_contigs_not_scaffolds = false |
I think I would rather be more explicity: --spades_outputtype contigs
with enum contigs or scaffolds (Scaffolds as default for backgfwards compatibility)
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).