-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add porechop
module
#914
add porechop
module
#914
Conversation
HI our module successfully passes tests for docker and singularity, however the md5 checksums don't pass for conda, as we are getting different checksums in different systems (e.g. github actions vs locally). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the conda thing is annoying, it works for docker & singularity with the checksums, right? I think we can just merge then anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I just have some super minor suggestions.
I think the github repo links work better then the anaconda ones since they have more info. But I'm really interested to get your thoughts on _porechop
vs $options.suffix
Cheers
Co-authored-by: Robert A. Petit III <[email protected]>
Co-authored-by: Robert A. Petit III <[email protected]>
Thanks for your reviews @rpetit3 and @FriederikeHanssen I've included all your review comments |
Added missing porechop module by the Golden Delicious 🍏 team
PR checklist
Closes #827
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd