Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gzip reference files #133

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Fix gzip reference files #133

merged 5 commits into from
Feb 15, 2024

Conversation

edmundmiller
Copy link
Collaborator

@edmundmiller edmundmiller commented Feb 14, 2024 •
edited
Loading

Closes #119

@edmundmiller edmundmiller self-assigned this Feb 14, 2024
@edmundmiller edmundmiller added this to the 2.2.0 milestone Feb 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7b11555

+| ✅ 168 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.1.1
  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file
  • pipeline_todos - TODO string in WorkflowNascent.groovy: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html

✅ Tests passed:

Run details

  • nf-core/tools version 2.12.1
  • Run at 2024-02-15 15:49:44

maxulysse
maxulysse approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you have some test failures

@edmundmiller edmundmiller merged commit 482bfa1 into dev Feb 15, 2024
4 checks passed
@edmundmiller edmundmiller deleted the gzip-references branch February 15, 2024 18:40
@edmundmiller edmundmiller linked an issue Feb 15, 2024 that may be closed by this pull request
Issues of creating BWA index with custom fasta and GTF #119
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Issues of creating BWA index with custom fasta and GTF
2 participants
@edmundmiller @maxulysse