Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nf-schema): replace [email protected] by [email protected] #1287

Closed
wants to merge 4 commits into from
Closed

feat(nf-schema): replace [email protected] by [email protected] #1287

wants to merge 4 commits into from

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

nvnieuwk
nvnieuwk approved these changes Apr 23, 2024
View reviewed changes
Copy link

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@kubranarci kubranarci mentioned this pull request Apr 24, 2024
Closed
@adamrtalbot adamrtalbot linked an issue Apr 30, 2024 that may be closed by this pull request
Replace nf-validation with nf-schema #1290
Closed
adamrtalbot
adamrtalbot approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@adamrtalbot adamrtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heck yeah.

@maxulysse
Copy link
Member Author

We just need tools to be updated now

@drpatelh drpatelh added this to the 3.15.0 milestone May 13, 2024
@drpatelh
Copy link
Member

Waiting for v2.15.0 where nf-validation will be replaced by nf-schema in the pipeline template. Will convert to draft for now.

@drpatelh drpatelh marked this pull request as draft May 13, 2024 08:33
@pinin4fjords
Copy link
Member

Waiting for v2.15.0 where nf-validation will be replaced by nf-schema in the pipeline template. Will convert to draft for now.

So this is no longer to be done for 2.15.0 then? I'll remove from the milestone

@pinin4fjords pinin4fjords removed this from the 3.15.0 milestone May 29, 2024
@maxulysse
Copy link
Member Author

Still waiting on tools 2.15 for this, but I'd say it's unlikely to happen before we release this pipeline 3.15, so...

@nvnieuwk
Copy link

Working on it! :p

@maxulysse maxulysse closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvnieuwk nvnieuwk nvnieuwk approved these changes

@adamrtalbot adamrtalbot adamrtalbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace nf-validation with nf-schema
5 participants
@maxulysse @drpatelh @pinin4fjords @nvnieuwk @adamrtalbot