Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow integer sample names #1421

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

idot
Copy link

@idot idot commented Oct 18, 2024

int was not allowed as sample name anymore (since 3.16.0)
Validation of file failed:
-> Entry 1: Error for field 'sample' (298098): Sample name must be provided and cannot contain spaces

PR checklist

  • [*] This comment contains a description of changes (with reason).

  • CHANGELOG.md is updated.

 Validation of file failed:
        -> Entry 1: Error for field 'sample' (298098): Sample name must be provided and cannot contain spaces
Copy link

github-actions bot commented Oct 18, 2024

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@idot idot changed the base branch from master to dev October 18, 2024 11:45
@idot
Copy link
Author

idot commented Oct 18, 2024

fixes #1419

@pinin4fjords
Copy link
Member

pinin4fjords commented Jan 16, 2025

@idot can you confirm that you've tested the workflow with this change? Also, please update the CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants