-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to add a custom annotation, clarified multiQC results and fixed issues #401
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
94d6d1f
Added additional_annot param
svarona b7cc316
Added param additional_annot channel
svarona 2fdd8aa
Added ADDITIONAL_ANNOT process
svarona 9740161
Added additional_annot subworkflow
svarona cafa3b4
Added option to detec annotation format in snpeff build
svarona c750f38
variants long table more than one annotation, remove upstream and dow…
svarona 15d9919
Rename output file for additional annotation variants long table
svarona 6d834f2
Fixed black linting
svarona 90a9f93
changed default value for additional_annot path to null
svarona 27f4614
Added changes to changelog
svarona cbab17b
added description for additional_variants_long_table
svarona b57d083
Merge branch 'custom_gtf' into dev
svarona ba86890
Merge dev into custom_gtf
svarona 257ed47
Fixed additional annot subworkflow for new modules version
svarona ea073b5
Added gunzip for additional annot too
svarona 63d4ca6
Added CI test for additional annot
svarona c083ec6
fixed prettier
svarona 864285a
Added variants long table explanation for nanopore
svarona 398c46f
added default values to multiQC to clarify variants annotated
svarona be2949e
Added a clearer description of long table
svarona 553f689
Merge branch 'dev' into custom_gtf
svarona 10614e1
Merge branch 'dev' into custom_gtf
svarona c84e0c4
Fixed prettier
svarona 75b7935
Added custom gtf to nanopre data
svarona a256109
added tests
svarona d920bf9
Fixed placing of download gtf
svarona 0d5d826
Merge branch 'dev' into custom_gtf
svarona a2b78a6
Only downloading additional gtf file when using param
svarona 63bf5ad
Renamed additional_annot with additional_annotation
svarona 5e44727
Fixed prettier
svarona 9cacdc2
Fixed bed channel for issue #419
svarona File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could mention the optional
.gz
.I assume there's no need to decompress in such case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the same format as the --gff param
Should I add the .gz in the description for both? Both of them have a
GUNZIP_GFF
process in the case they are compressed.