Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old hackathons, reorganise components for new projects #3031

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

ewels
Copy link
Member

@ewels ewels commented Feb 3, 2025

Turns out that our fancy new hackathon project listing broke old hackathon event pages: https://nf-co.re/events/2024/hackathon-barcelona#list-of-projects

I added back the old components to fix those, then reorganised the various components for the new hackathon project listing into a directory to keep them together.

@netlify /events/2025/hackathon-march-2025

@ewels ewels requested a review from mashehu February 3, 2025 11:05
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for nf-core-main-site ready!

Name Link
🔨 Latest commit 2026a94
🔍 Latest deploy log https://app.netlify.com/sites/nf-core-main-site/deploys/67a0a39e0cdfe200082bc5e5
😎 Deploy Preview https://deploy-preview-3031--nf-core-main-site.netlify.app/events/2025/hackathon-march-2025
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ewels
Copy link
Member Author

ewels commented Feb 3, 2025

The git diff is getting very confused because of the filenames, but basically:

  • sites/main-site/src/components/event/HackathonGroup.astro
    • Previous version of this component, from here
  • Everything else: moved into a HackathonProjects directory to keep them together, with renamed files.

I think that these are the only meaningful changes.

@nf-core nf-core deleted a comment from netlify bot Feb 3, 2025
@ewels ewels merged commit 09b9fd4 into nf-core:main Feb 3, 2025
12 checks passed
@ewels ewels deleted the hackathon-projects-fix-reorganise branch February 3, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants