Merge seek 1.15.1 into LDH #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the authlookup queue every 8 hours #1866
…gistered user #1866
needs tests, but see what tests are affected first
…atches of 8000 #1866
…ymous user checks #1866
…set and limit #1866
…eam_permissions Issue 1868 fix assay stream permissions
show progress for decouple_extracted_samples_policies and decouple_extracted_samples_projects, after every batch of 250 also update the query for decouple_extracted_samples_projects to select those without projects, making reruns quicker
…lr_enabled is false #1874
* Add to the config
…tions internationalize the names in the search types. Closes #1879
…tton when an existing template is shown.
…sions or clicking on the "Back to Model" button. issue #1926:
Lost temporary access code in the URL when switching between versions or clicking on the "Back to Model" button.
If not set manually, it will append a random integer after ... type.
Fix populate templates job
add an alert message to remind users to confirm addin the Remote URL
ReneHaensel
requested review from
MasoudAbedi
and removed request for
whomingbird and
MasoudAbedi
|
could you please describe the new features of the PR? |
whomingbird
reviewed
Jul 10, 2024
| project_attributes_json = ProjectSerializer.new(@project).to_json | ||
|
|
||
| @user_current = current_person | ||
| special_characters = { |
There was a problem hiding this comment.
can this move to a function ?
whomingbird
reviewed
Jul 10, 2024
| @@ -543,77 +543,206 @@ def order_investigations | |||
|
|
|||
| def publish_to_csh | |||
There was a problem hiding this comment.
i think the most of code of the "publish_to_csh" should be move to a module in lib/nfdi4health, the code for preparing and parsing json could be reused by other resource to publish to CSH.
There was a problem hiding this comment.
ldh/app/controllers/projects_controller.rb
Line 552 in 52132af
ldh/app/controllers/studies_controller.rb
Line 364 in 52132af
whomingbird
reviewed
Jul 10, 2024
Comment on lines
+66
to
+69
| <% if Seek::Config.n4h_enabled && item.extended_metadata != nil %> | ||
| <li><%= image_tag_for_key('publish', publish_to_csh_project_path(item), "Publish to NFDI4Health GCHSH", nil, "Publish to NFDI4Health GCHSH") -%></li> | ||
| <% else %> | ||
| <% explanation = "The 'Publish to NFDI4Health GCHSH' item for #{text_for_resource(item).pluralize.downcase} in Server admin panel was deactivated by the admin." %> | ||
| <% explanation = "Your project does not include metadata, or The 'Publish to NFDI4Health GCHSH' item for #{text_for_resource(item).pluralize.downcase} in Server admin panel was deactivated by the admin." %> |
There was a problem hiding this comment.
this should be moved to the ProjectsHelper
Seek::Config.n4h_enabled && item.extended_metadata != nil, this code looks weird
whomingbird
reviewed
Jul 10, 2024
There was a problem hiding this comment.
Main Concerns:
- Modularization:
Move the publish_to_csh functionality to a module within lib/nfdi4health. This will enhance modularity and allow the code for preparing and parsing JSON to be reused by other resources needing to publish to CSH. - Testing:
Add tests to ensure the reliability and correctness of the publish_to_csh functionality. In the SEEK main branch, writing tests is a crucial part of SEEK development. Any feature cannot be merged into the main branch without proper tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Features / major changes