Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the 8 remaining templates needed to create the ARC for TRR341 phenotyping experiments #90

Merged
merged 7 commits into from
Nov 21, 2023

Conversation

JulieTRR341
Copy link
Contributor

Can you add the last 8 templates I created in the database?

@JulieTRR341
Copy link
Contributor Author

@Brilator

@Brilator
Copy link
Member

I've checked the templates and they seemed fine.

  • deleted some left over values (from hidden columns)
  • tried to add proper unit ontologies: when adding building blocks with units, make sure to click the "Update Ontology Terms" button once before saving

@Brilator
Copy link
Member

To keep things a bit easier to comment and merge, do us a favor and try not to add too many templates at the same time.
I'd rather recommend to do one template per PR.

@Brilator Brilator merged commit ed5f0ce into nfdi4plants:main Nov 21, 2023
1 check passed
@JulieTRR341
Copy link
Contributor Author

Ok, sorry! I actually thought it would be much more complicated if I created a Pulling request for each template. I will know better next time!

@Brilator
Copy link
Member

I mean it's fine, since apparently all templates were technically sound!

@JulieTRR341
Copy link
Contributor Author

I just realized that the Protocol columns do not appear in my templates when I upload them in SWATE. Although there are there in the original excel files. Is there a good reason why they would not show up?

@Brilator
Copy link
Member

There's no "good reason", but a technical one... they are currently not supported.

@JulieTRR341
Copy link
Contributor Author

haaa too bad, I hope we can change that, it would be really good to have them

@JulieTRR341
Copy link
Contributor Author

@Brilator One of the template, the Study_Event_protocol_TRR341_MIAPPE, does not show up in the Template Database on SWATE, was it forgotten at one of the steps? Should I create a new pull request for this one? Sorry for all that

@Brilator
Copy link
Member

Oh. Well, give it a try.

@JulieTRR341
Copy link
Contributor Author

for the moment, I still don't see it in the database

@Brilator
Copy link
Member

Here's the warning I get:

"Could not parse sheet "Event_protocol": For the protocol with the name Event_protocol, two different protocol Types Some({ ID = None Name = Some (Text "Events") TermSourceREF = None TermAccessionNumber = None Comments = Some [{ ID = None Name = Some "ValueIndex" Value = Some "0" }] }) and Some({ ID = None Name = None TermSourceREF = None TermAccessionNumber = None Comments = Some [{ ID = None Name = Some "ValueIndex" Value = Some "0" }] }) were given, which is not allowed" @/api/IISADotNetCommonAPIv1/toSwateTemplateJson.

This basically means, there cannot be two different values (1. "Events" and 2. nothing) in one building block.

Screenshot 2023-11-21 at 17 31 28

@Brilator
Copy link
Member

Fixed it cbea47b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants