CRAN v1.3.1

.github/workflows/R-CMD-check.yaml

@@ -29,6 +29,8 @@ jobs:
     env:
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
       R_KEEP_PKG_SOURCE: yes
+      _R_CHECK_EXAMPLE_TIMING_CPU_TO_ELAPSED_THRESHOLD_: "2.5"
+      _R_CHECK_TEST_TIMING_CPU_TO_ELAPSED_THRESHOLD_: "NA"
 
     steps:
       - uses: actions/checkout@v3

CRAN-SUBMISSION

@@ -0,0 +1,3 @@
+Version: 1.3.1
+Date: 2024-03-25 12:31:30 UTC
+SHA: 7dd173bbc44f36fe18c7f76a877684469a5a98b0

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: nflplotR
 Title: NFL Logo Plots in 'ggplot2' and 'gt'
-Version: 1.3.0
+Version: 1.3.1
 Authors@R: 
     person("Sebastian", "Carl", , "[email protected]", role = c("aut", "cre"))
 Description: A set of functions to visualize National Football League

NEWS.md

@@ -1,3 +1,7 @@
+# nflplotR 1.3.1
+
+* Adjusted internals by CRAN request. No visible changes for the user. (#60)
+
 # nflplotR 1.3.0
 
 ## New Features

R/theme-elements.R

@@ -9,9 +9,6 @@
 #'   - `element_nfl_headshot()`: draws NFL player headshots instead of their GSIS IDs.
 #'   - `element_path()`: draws images from valid image URLs instead of the URL.
 #'
-#' @inheritParams ggpath::element_path
-#' @inheritDotParams ggpath::element_path
-#'
 #' @details The elements translate NFL team abbreviations or NFL player GSIS IDs
 #'   into logo images or player headshots, respectively.
 #' @param alpha The alpha channel, i.e. transparency level, as a numerical value
@@ -23,6 +20,7 @@
 #' @param hjust,vjust The horizontal and vertical adjustment respectively.
 #'   Must be a numerical value between 0 and 1.
 #' @param size The output grob size in `cm` (!).
+#' @param ... Arguments passed on to [ggpath::element_path]
 #' @seealso [geom_nfl_logos()], [geom_nfl_headshots()], [geom_nfl_wordmarks()],
 #'   and [geom_from_path()] for more information on valid team abbreviations,
 #'   player IDs, and other parameters.

R/zzz.R

@@ -27,24 +27,24 @@
   # (EDIT: They probably use different ones in R DEVEL)
   # which means "more than two cores are running".
   # We check for these environment variables and if we find them
-  # we set data.table to two threads and the OMP library
+  # we set data.table to two threads
   # nflplotR depends on magick which also uses OMP but doesn't respect
   # OMP_THREAD_LIMIT. I have to skip the related tests unfortunately.
-  cpu_check <- as.numeric(
-    c(
+  cpu_check <- suppressWarnings(stats::na.omit(as.numeric(c(
       Sys.getenv("_R_CHECK_EXAMPLE_TIMING_CPU_TO_ELAPSED_THRESHOLD_", unset = 0),
       Sys.getenv("_R_CHECK_TEST_TIMING_CPU_TO_ELAPSED_THRESHOLD_", unset = 0)
-    )
-  )
+    ))))
 
   if (any(cpu_check != 0)) {
-    cores <- min(
+    cores <- suppressWarnings(min(
       floor(as.integer(Sys.getenv("_R_CHECK_EXAMPLE_TIMING_CPU_TO_ELAPSED_THRESHOLD_"))),
       floor(as.integer(Sys.getenv("_R_CHECK_TEST_TIMING_CPU_TO_ELAPSED_THRESHOLD_"))),
       2L,
       na.rm = TRUE
-    )
+    ))
     Sys.setenv("OMP_THREAD_LIMIT" = cores)
+    # see https://stat.ethz.ch/pipermail/r-package-devel/2023q4/009969.html
+    Sys.setenv("OMP_NUM_THREADS" = cores)
     data.table::setDTthreads(cores)
   }
 }

cran-comments.md

@@ -1,6 +1,6 @@
 ## Submission
 
-This is a minor release that updates internal files and improves some functions.
+This is a minor release that updates internal functionality requested by CRAN.
 
 ## R CMD check results
 

tests/testthat/test-nfl_team_tiers.R

@@ -1,4 +1,7 @@
 test_that("team tiers work", {
+  # skip because of data.table multithreading
+  skip_on_cran()
+
   library(ggplot2)
   teams <- nflplotR::valid_team_names()
   # remove conference logos from this example

vignettes/articles/nflplotR.Rmd

@@ -344,6 +344,12 @@ ggplot(df, aes(x = mpg, y = disp)) +
   )
 ```
 
+```{r, echo=FALSE, message=FALSE}
+# the pkgdown workflow ran in cache size problems
+# so we clear the cache here hoping to resolve the issue
+nflplotR::.nflplotR_clear_cache()
+```
+
 Or maybe facet by player and use headshots...
 
 ```{r}