Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Buffs to GetCombatants #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added Buffs to GetCombatants #220

wants to merge 1 commit into from

Conversation

jrsmile
Copy link

@jrsmile jrsmile commented Sep 8, 2021

chat result with valarin about missing information compared to EnmityAggroList, should allow to get the same information when combining PartyChanged event and GetCombatants as EnmityAggroList.

A EnmityPartyList would still be better.

chat result with valarin about missing information comapred to EnmityAggroList
@ngld
Copy link
Owner

ngld commented Nov 19, 2021

Sorry for taking so long...

I don't like adding Effects as a supported property since unlike the other fields, it's not a primitive type. However, the new parser for 6.0 replaces that field with NetworkBuffs so I'd rather wait until then and add the new field (if the JSON encoder can handle it) instead of the old Effects field.

Long term, a better solution would be to remove the current PartyChanged and GetCombatants implementations and replace them with the custom memory logic that's used for EnmityAggroList.
For context: PartyChanged and GetCombatants use data from the FFXIV parser (which doesn't keep track of enmity) and EnmityAggroList reads data directly from the game's memory. This allows the latter to read enmity as well but requires more maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants