Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds recheck action #205

Merged
merged 1 commit into from
May 8, 2024
Merged

adds recheck action #205

merged 1 commit into from
May 8, 2024

Conversation

tomjemmett
Copy link
Member

  • added unit tests and checked code coverage with covr::report() (should aim for 100%)
  • ran devtools::document()
  • ran lintr::lint_package() and resolved all lint warnings and notes
  • ran styler::style_pkg() to make sure code matches the style guidelines
  • ran R-CMD CHECK and resolved all issues

@tomjemmett tomjemmett added the enhancement New feature or request label May 8, 2024
@tomjemmett tomjemmett self-assigned this May 8, 2024
@tomjemmett tomjemmett requested a review from ThomUK May 8, 2024 13:47
Copy link
Collaborator

@ThomUK ThomUK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.
Shall we fix the lint issue in the other PR?

@ThomUK
Copy link
Collaborator

ThomUK commented May 8, 2024

Just to add @tomjemmett I don't have merge rights on this repo, so please feel free to merge if you do...

@tomjemmett tomjemmett merged commit 1ea3d97 into main May 8, 2024
8 of 9 checks passed
@tomjemmett tomjemmett deleted the add_recheck_action branch May 8, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants