-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRMP-1229] Create alarm for EdgePresignLambda #239
base: main
Are you sure you want to change the base?
Conversation
} | ||
} | ||
|
||
resource "aws_cloudwatch_metric_alarm" "edge_presign_lambda_error_alarm" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edge_presign_lambda_error
@@ -9,6 +9,31 @@ module "edge_presign_alarm" { | |||
depends_on = [module.edge-presign-lambda, module.edge_presign_alarm_topic] | |||
} | |||
|
|||
resource "aws_cloudwatch_log_metric_filter" "edge_presign_error_filter" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edge_presign_error
resource "aws_cloudwatch_log_metric_filter" "edge_presign_error_filter" { | ||
name = "EdgePresignError" | ||
pattern = "%LambdaError%" | ||
log_group_name = "/aws/lambda/us-east-1.${module.edge-presign-lambda.function_name}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
us-east-1.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed by Steph that this is the correct name for the log group due to it being an edge lambda.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review feedback was addressed. Happy with this now.
No description provided.