Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRMP-1229] Create alarm for EdgePresignLambda #239

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

steph-torres-nhs
Copy link
Contributor

No description provided.

@steph-torres-nhs steph-torres-nhs changed the title PRMP-1229 Create alarm for EdgePresignAlarm PRMP-1229 Create alarm for EdgePresignLambda Jan 24, 2025
}
}

resource "aws_cloudwatch_metric_alarm" "edge_presign_lambda_error_alarm" {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edge_presign_lambda_error

@@ -9,6 +9,31 @@ module "edge_presign_alarm" {
depends_on = [module.edge-presign-lambda, module.edge_presign_alarm_topic]
}

resource "aws_cloudwatch_log_metric_filter" "edge_presign_error_filter" {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edge_presign_error

resource "aws_cloudwatch_log_metric_filter" "edge_presign_error_filter" {
name = "EdgePresignError"
pattern = "%LambdaError%"
log_group_name = "/aws/lambda/us-east-1.${module.edge-presign-lambda.function_name}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

us-east-1.?

Copy link
Contributor

@AndyFlintNHS AndyFlintNHS Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed by Steph that this is the correct name for the log group due to it being an edge lambda.

@chrisbloe-nhse chrisbloe-nhse changed the title PRMP-1229 Create alarm for EdgePresignLambda [PRMP-1229] Create alarm for EdgePresignLambda Jan 30, 2025
Copy link
Contributor

@AndyFlintNHS AndyFlintNHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review feedback was addressed. Happy with this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants