-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add panel component #1012
base: main
Are you sure you want to change the base?
Add panel component #1012
Conversation
@davidhunter08 can you add some screenshots? |
@davidhunter08 Thoughts on padding? I can see this totals 40px with the border and padding. Our cards tend to have 32px padding. I wonder whether this should have the same padding amount as cards? Possibly not an issue since they shouldn't ever appear on the same page. But worth considering? Side note, any idea why the panel includes a 4px border? I assume for print/high-contrast styles? |
It makes sense and looks ok having the padding 32px.
I presumed this was for changed/forced colours, same as the buttons, but I haven't tested it. We can test in the accessibility lab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Left some minor suggestions.
I also tested it locally without the body as I don’t think that’ll always be needed, and looks good.
Co-authored-by: Frankie Roberto <[email protected]>
Co-authored-by: Frankie Roberto <[email protected]>
Description
Add panel component for use on confirmation pages.
Large screens
Small screens
Checklist