Merge pull request #100 from nhsuk/fix-code-smells

Fix SonarCloud code smells
nhsuk · Jan 8, 2024 · 1907c26 · 1907c26
2 parents 3ea156a + c0e638c
commit 1907c26
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/README.md b/README.md
@@ -43,7 +43,12 @@ The latest javascript file can be found in github releases https://github.com/nh
 
 #### Attributes
 
-`data-form-endpoint` - (required) An HTTP data store endpoint to POST data to. Include the trailing slash
+`data-form-endpoint` - (required) An HTTP data store endpoint to POST data to. Include the trailing slash. The endpoint setting should probably be this:
+
+```html
+<div id="nhsuk-user-feedback-form" data-form-endpoint="http://localhost:7071/"></div>
+```
+
 `data-enable-text-response` - (optional) Include to enable text responses on the feedback form.
 
 ## API

diff --git a/tests/example/enabled-text-response.html b/tests/example/enabled-text-response.html
@@ -1,4 +1,5 @@
-<html>
+<!DOCTYPE html>
+<html lang="en">
   <head>
     <meta charset="utf-8">
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
@@ -18,11 +19,6 @@
       <main class="nhsuk-main-wrapper">
         <h1>User feedback form:</h1>
         <div id="nhsuk-user-feedback-form" data-form-endpoint="http://localhost:8080/my-endpoint/" data-enable-text-response></div>
-
-        <!--
-        If you have the user-feedback-store running locally and want to test it, the endpoint setting should probably be this:
-        <div id="nhsuk-user-feedback-form" data-form-endpoint="http://localhost:7071/"></div>
-        -->
       </main>
     </div>
   </body>

diff --git a/tests/example/index.html b/tests/example/index.html
@@ -1,4 +1,5 @@
-<html>
+<!DOCTYPE html>
+<html lang="en">
   <head>
     <meta charset="utf-8">
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
@@ -18,11 +19,6 @@
       <main class="nhsuk-main-wrapper">
         <h1>User feedback form:</h1>
         <div id="nhsuk-user-feedback-form" data-form-endpoint="http://localhost:8080/my-endpoint/"></div>
-
-        <!--
-        If you have the user-feedback-store running locally and want to test it, the endpoint setting should probably be this:
-        <div id="nhsuk-user-feedback-form" data-form-endpoint="http://localhost:7071/"></div>
-        -->
       </main>
     </div>
   </body>