[Core] Don't divide zero by zero #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mikejsavage, thanks for the good catch! I actually noticed another bug related to downsizing when I was investigating thing, would you be able to try out my change and confirm it fixes your bug correctly? 🙂 |
nicbarker
added
bug
|
Yep your change works too, and produces identical results to what I tried |
|
Awesome! Will merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting crashes here with floating point exceptions enabled.
This may not be a good fix but at least the resulting layout looks fine again, I can put together a repro if you think this is the wrong way to do it.