SDL3: Add rounded corners rectangle functionality #219
+127
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnauNau
commented
Jan 22, 2025
There was a problem hiding this comment.
Alternate radius value discussion. The RayLib module compares topRight corner radius with boundingBox and chooses one of the two depending on the comparison result. I'm not sure why it does that but I've added the same logic but left it commented out so if someone knows why it's there and it's needed it can be quickly added to the SDL3 module by uncommenting that and commenting the current call.
| SDL_SetRenderDrawColor(renderer, color.r, color.g, color.b, color.a); | ||
| SDL_RenderFillRect(renderer, &rect); | ||
| if (config->cornerRadius.topLeft > 0) { | ||
| //const float radius = (config->cornerRadius.topLeft * 2) / (float)((bounding_box.width > bounding_box.height) ? bounding_box.height : bounding_box.width); |
There was a problem hiding this comment.
This is done in the RayLib renderer module, left it here commented in case anyone (Nic maybe) knows why and if it needs to be done here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added one of the missing features for the SDL3 renderer.