-
Notifications
You must be signed in to change notification settings - Fork 43
Support the Switch SNES Controller #27
base: master
Are you sure you want to change the base?
Conversation
src/hid-nintendo.c
Outdated
(ctlr->ctlr_type == JOYCON_CTLR_TYPE_JCR || \ | ||
ctlr->ctlr_type == JOYCON_CTLR_TYPE_PRO) | ||
|
||
/* Does this controller have a home button? */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
home button -> rumble
can anyone confirm that the above works with master and i ll merge it |
If anyone wants to test it they'll probably want to use the changes in joycond here too: |
@ChadSikorra You may want to submit this PR to https://github.com/DanielOgorchock/linux as well I think |
This somehow messes up pro-controller support...kernel panic :( *sigh* Trying to debug. Not sure specifically what would've done that after looking at what I changed. Will have to take a closer look, unless someone can spot it. |
… it, even it not supported). Just ignore the IMU data if not available.
I modified it slightly so that it still lets certain things to be enabled via the protocol -- rumble / imu (which just ignores things certain controllers don't support it seems). This makes the driver behave better when both SNES / pro controller / joy cons are used. I tested with the Pro Controller and the SNES controller. |
Any update on pulling this in? |
i mean i cannot really test it ... i only got joycons and pro controllers.. if anyone can for a week or so and does not find any issues i ll pull it after testing for regressions |
Been trying to test this, but unable to connect the SNES Controller in the first place. RetroPi recognizes it as paired, but the SNES controller gets stuck in pairing mode. Getting the error "Failed to pair: org.bluez.Error.AlreadyExists." Has anybody else had luck pairing the controller? |
I don't understand. |
This makes some changes so that it works with the Switch SNES controller. The SNES controller lacks some of the features of the joycons / pro controller, so I had to add some additional checks to leave things out (gyro, rumble, home button are all missing on the SNES controller).