Skip to content

Commit

Permalink
[ie/Soundcloud] Extract artists (yt-dlp#11377)
Browse files Browse the repository at this point in the history
Closes yt-dlp#11375
Authored by: seproDev
  • Loading branch information
seproDev authored Oct 28, 2024
1 parent 3303353 commit f101e5d
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions yt_dlp/extractor/soundcloud.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,6 @@ def sign(self, user, pw, clid):

def _extract_info_dict(self, info, full_title=None, secret_token=None, extract_flat=False):
track_id = str(info['id'])
title = info['title']

format_urls = set()
formats = []
Expand Down Expand Up @@ -367,7 +366,7 @@ def extract_count(key):
'uploader_id': str_or_none(user.get('id')) or user.get('permalink'),
'uploader_url': user.get('permalink_url'),
'timestamp': unified_timestamp(info.get('created_at')),
'title': title,
'title': info.get('title'),
'description': info.get('description'),
'thumbnails': thumbnails,
'duration': float_or_none(info.get('duration'), 1000),
Expand All @@ -377,7 +376,8 @@ def extract_count(key):
'like_count': extract_count('favoritings') or extract_count('likes'),
'comment_count': extract_count('comment'),
'repost_count': extract_count('reposts'),
'genres': traverse_obj(info, ('genre', {str}, {lambda x: x or None}, all)),
'genres': traverse_obj(info, ('genre', {str}, filter, all, filter)),
'artists': traverse_obj(info, ('publisher_metadata', 'artist', {str}, filter, all, filter)),
'formats': formats if not extract_flat else None,
}

Expand Down Expand Up @@ -429,7 +429,6 @@ class SoundcloudIE(SoundcloudBaseIE):
'repost_count': int,
'thumbnail': 'https://i1.sndcdn.com/artworks-000031955188-rwb18x-original.jpg',
'uploader_url': 'https://soundcloud.com/ethmusic',
'genres': [],
},
},
# geo-restricted
Expand All @@ -453,6 +452,7 @@ class SoundcloudIE(SoundcloudBaseIE):
'uploader_url': 'https://soundcloud.com/the-concept-band',
'thumbnail': 'https://i1.sndcdn.com/artworks-v8bFHhXm7Au6-0-original.jpg',
'genres': ['Alternative'],
'artists': ['The Royal Concept'],
},
},
# private link
Expand Down Expand Up @@ -525,6 +525,7 @@ class SoundcloudIE(SoundcloudBaseIE):
'repost_count': int,
'view_count': int,
'genres': ['Dance & EDM'],
'artists': ['80M'],
},
},
# private link, downloadable format
Expand All @@ -549,6 +550,7 @@ class SoundcloudIE(SoundcloudBaseIE):
'thumbnail': 'https://i1.sndcdn.com/artworks-000240712245-kedn4p-original.jpg',
'uploader_url': 'https://soundcloud.com/oriuplift',
'genres': ['Trance'],
'artists': ['Ori Uplift'],
},
},
# no album art, use avatar pic for thumbnail
Expand All @@ -572,7 +574,7 @@ class SoundcloudIE(SoundcloudBaseIE):
'comment_count': int,
'repost_count': int,
'uploader_url': 'https://soundcloud.com/garyvee',
'genres': [],
'artists': ['MadReal'],
},
'params': {
'skip_download': True,
Expand Down

0 comments on commit f101e5d

Please sign in to comment.