Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from deprecated pkg_resources #212

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Move away from deprecated pkg_resources #212

merged 2 commits into from
Nov 27, 2023

Conversation

parona-source
Copy link
Contributor

  • Use importlib.metadata which has been included in the python standard library since 3.8.

@parona-source
Copy link
Contributor Author

This is not urgent, there is no ETA on any sort of removal. Just one less deprecation warning.

@parona-source
Copy link
Contributor Author

Surprised that 3.7 is still in the CI. https://devguide.python.org/versions/ eol'd a couple months ago and not supported ubuntu version defaults to it either (focal 3.8).

3.7 CI could be fixed by using the importlib_metadata backport.

nicolasbock
nicolasbock requested changes Nov 17, 2023
View reviewed changes
Copy link
Owner

@nicolasbock nicolasbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we can safely remove the Python 3.7 tests from the GitHub workflows. Could you add the necessary changes to this PR? Thanks!

@parona-source
Drop Python 3.7 support, Add 3.11 and 3.12 support
5002718 
Signed-off-by: Alfred Wingate <[email protected]>
@parona-source
Move away from deprecated pkg_resources
e95c342 
* Use importlib.metadata which has been included in the python standard
  library since 3.8.

Signed-off-by: Alfred Wingate <[email protected]>
@parona-source
Copy link
Contributor Author

Added 3.11 and 3.12 at while at it.

nicolasbock
nicolasbock approved these changes Nov 17, 2023
View reviewed changes
Copy link
Owner

@nicolasbock nicolasbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@parona-source
Copy link
Contributor Author

parona-source commented Nov 17, 2023 •
edited
Loading 

(           index: line    2) broken    https://github.com/nicolasbock/ebuildtester/workflows/build/badge.svg - 404 Client Error: Not Found for url: https://github.com/nicolasbock/ebuildtester/workflows/build/badge.svg
...
build finished with problems, 3 warnings.
ERROR: InvocationError for command /home/runner/work/ebuildtester/ebuildtester/.tox/docs/bin/sphinx-build -M linkcheck docs docs/_build (exited with code 1)
___________________________________ summary ____________________________________
ERROR:   docs: commands failed
Error: Process completed with exit code 1.

@parona-source
Copy link
Contributor Author

#214

@nicolasbock nicolasbock merged commit decf520 into nicolasbock:main Nov 27, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasbock nicolasbock nicolasbock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parona-source @nicolasbock