Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix --with-vnc option #226

Merged
merged 2 commits into from
Oct 19, 2024
Merged

fix --with-vnc option #226

merged 2 commits into from
Oct 19, 2024

Conversation

stkw0
Copy link
Collaborator

@stkw0 stkw0 commented Oct 13, 2024

No description provided.

@stkw0 stkw0 requested a review from nicolasbock as a code owner October 13, 2024 17:58
@stkw0 stkw0 changed the title Dev fix --with-vnc option Oct 13, 2024
nicolasbock
nicolasbock approved these changes Oct 13, 2024
View reviewed changes
Copy link
Owner

@nicolasbock nicolasbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolasbock
Copy link
Owner

Can you fix the test?

@stkw0
Copy link
Collaborator Author

stkw0 commented Oct 13, 2024

fix

I ""fixed"" it. That is, I removed the test, given that with-basic-packages option was not tested and that it was no longer in atoms, I thought was not that much bad to drop that particular test (:

@stkw0 stkw0 merged commit 447322f into nicolasbock:main Oct 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasbock nicolasbock nicolasbock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stkw0 @nicolasbock