Add log-file-path option #600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilaoda
reviewed
Feb 4, 2025
| var dir = Path.GetDirectoryName(input); | ||
| var filename = Path.GetFileName(input); | ||
| var newName = OtherUtil.GetValidFileName(filename); | ||
| if (string.IsNullOrEmpty(newName)) |
There was a problem hiding this comment.
It is necessary to support inputting relative paths or scenarios where only the filename is provided. With absolute path, should check whether the path is correct and maybe creating the folder if it does not exist.
There was a problem hiding this comment.
I added support for relative paths. Path.GetFullPath() raises an exception if the path is not valid so that should be enough to ensure the path is correct. The folder is also created at Logger.InitLogFile() if it doesn't exist.
I tested it with a bunch of absolute and relative paths and it seems to be working (I could only test it in linux but C# Path should work for all platforms). Let me know if something is missing :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #581
This adds an argument to specify the file where the logs will be written.