fixes #19162; enable strictEffects for v2
#19380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests need to be updated but important packages seem to work, so please proceed. |
|
Here is the progress of fixing important packages: |
|
made a PR for arraymancer: mratsim/Arraymancer#549 |
mratsim
pushed a commit
to mratsim/Arraymancer
that referenced
this pull request
Jan 21, 2022
* add stricteffects support ref nim-lang/Nim#19380 * add more effectsof * more
33 tasks
ringabout
added a commit
that referenced
this pull request
Sep 23, 2022
ringabout
commented
Oct 14, 2022
ringabout
commented
Oct 14, 2022
ringabout
commented
Oct 14, 2022
ringabout
commented
Oct 14, 2022
ringabout
commented
Oct 14, 2022
Araq
reviewed
Oct 15, 2022
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
This was referenced Oct 31, 2022
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
* enable stricteffects * add gcsafe * fix tests * use func * fixes pegs tests * explicitly mark repr related procs with noSideEffect * add nimLegacyEffects * change URL * fixes docopt * add `raises: []` to repr * fixes weave * fixes nimyaml * fixes glob * fixes parsetoml * Apply suggestions from code review * Update testament/important_packages.nim * add legacy:laxEffects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19162
issues tracking
nim-regexto release a new tag Would you possibly add a new tag including patches for stricteffects? nitely/nim-regex#116fixes for stricteffects for Nim v2 GULPF/nimquery#19
mark unmarshal with gcsafe ba0f3/telebot.nim#79
make weave compile with gcsafe mratsim/weave#184
add patches for stricteffects HugoGranstrom/cdt#1
add patches for stricteffects SciNim/numericalnim#31
patches for strict effects NimParsers/parsetoml#58
5842184
.sideEffect'$'make nimyaml works with stricteffects flyx/NimYAML#125
fix: bump regex deps version haltcase/glob#58
make docopt compile with stricteffects docopt/docopt.nim#56
See also #19303