[std/os] split and re-export #20593
[std/os] split and re-export #20593
Conversation
|
You need to rebase. |
| from std/envvars import getEnv, existsEnv, delEnv, putEnv, envPairs | ||
| from std/os import dirExists, fileExists, walkDir, getAppFilename | ||
| from std/os import walkDir, getAppFilename, dirExists, fileExists |
There was a problem hiding this comment.
It will be changed to from std/private/oscommon import dirExists, fileExists in the following PRs because of bootstrapping.
|
fwiw, this is an unrelated CI failure /home/runner/.nimble/pkgs/measuremancer-0.1.1/measuremancer.nim(280, 15) Error: ambiguous call; both measuremancer.*(m: Measurement[*.U], x: T: FloatLike) [proc declared in /home/runner/.nimble/pkgs/measuremancer-0.1.1/measuremancer.nim(262, 6)] and measuremancer.*(m: Measurement[*.T], x: T: FloatLike) [proc declared in /home/runner/.nimble/pkgs/measuremancer-0.1.1/measuremancer.nim(265, 6)] match for: (T, float)
stack trace: (most recent call last) |
Oh, I had forgotten that |
|
I've written some tests, set up a CI for Aside from that, maybe |
Sounds good, it would be better if it is on the nimble packages indexes. |
Oh, I didn't realize I never added it. Will do. edit: here nim-lang/packages#2392 |
| ## * `removeFile proc`_ | ||
| ## * `moveFile proc`_ | ||
|
|
||
| doAssert card(copyFlagSymlink * options) == 1, "There should be exactly " & |
There was a problem hiding this comment.
Pre-existing but terrible API design! Instead of options: set[CopyFlag] it should have been option: CopyFlag!
|
|
||
| proc copyFileWithPermissions*(source, dest: string, | ||
| ignorePermissionErrors = true, | ||
| options = {cfSymlinkFollow}) {.noWeirdTarget.} = |
|
|
||
| if not tryMoveFSObject(source, dest, isDir = false): | ||
| when defined(windows): | ||
| doAssert false |
There was a problem hiding this comment.
Should have been raiseOSError or similar.
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
* [std/os] split and export * move to private modules * fixes docs and tests Co-authored-by: xflywind <[email protected]>
The PR intends to import/reexport
std/private/osfiles,std/private/ospaths2,std/private/osdirs,std/private/ossymlinksforstd/osmodule. #20582 should be a simple wrapper around these modules based on type safe definitions.The APIs for
std/paths,std/files,std/dirsandstd/symlinkswill be refined based on these components. There are not necessarily identical.