Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move threads out of system #20674

Merged
merged 19 commits into from
Oct 29, 2022
Merged

move threads out of system #20674

merged 19 commits into from
Oct 29, 2022

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Oct 27, 2022 •
edited
Loading

ref #20465

todo

  • cleanup

@ringabout ringabout changed the title move syslocks and threadlocalstorage to std/private move threads out of system Oct 27, 2022
@ringabout ringabout mentioned this pull request Oct 27, 2022
Closed
@ringabout
Copy link
Member Author

ringabout commented Oct 27, 2022 •
edited
Loading

ORC (goto exception) + tlsEmulation still failed, working on finding the cause.

There is no traceback, had to use gdb

Thread 3 received signal SIGSEGV, Segmentation fault.
[Switching to Thread 27164.0x3b0c]
0x00007ff70e323d13 in threadProcWrapper__test50_133 ()

@ringabout ringabout marked this pull request as draft October 27, 2022 15:30
@ringabout ringabout marked this pull request as ready for review October 28, 2022 10:54
@ringabout ringabout marked this pull request as draft October 28, 2022 10:56
@ringabout ringabout marked this pull request as ready for review October 29, 2022 07:42
@ringabout ringabout marked this pull request as draft October 29, 2022 07:44
@ringabout
Copy link
Member Author

ringabout commented Oct 29, 2022 •
edited
Loading

I don't want to introduce too many diffs in this PR, I will make std/threads under the umbrella of nimPreviewSlimSystem in the following PR.

in the following PR:

  • nimPreviewSlimSystem for std/threads + changelog
  • move channel_builtin to /deprecated and remove it if nimPreviewSlimSystem is enabled

@ringabout ringabout marked this pull request as ready for review October 29, 2022 13:08
@ringabout
Copy link
Member Author

ready for review

@Araq
Copy link
Member

Araq commented Oct 29, 2022

Ok. And yeah please do the follow-up PRs.

@Araq Araq merged commit 1dab8ba into devel Oct 29, 2022
@Araq Araq deleted the pr_threads_re branch October 29, 2022 16:11
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 1dab8ba

Hint: mm: orc; opt: speed; options: -d:release
164686 lines; 8.382s; 613.664MiB peakmem

capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@ringabout @capocasa
move threads out of system (nim-lang#20674)
129e8dd 
* move syslocks first

* progress

* clean up

* go on

* clean up

* clean up

* add imports syslocks

* remove documentation

* public deallocOsPages

* fixes genode

* fixes more

* fixes boehmGC

* cover more cases

* fixes cyclic deps

* fixes genode

* cleanup

* unpublic fields

* cleanup

* clean up
bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
@ringabout @bung87
move threads out of system (nim-lang#20674)
cacdf53 
* move syslocks first

* progress

* clean up

* go on

* clean up

* clean up

* add imports syslocks

* remove documentation

* public deallocOsPages

* fixes genode

* fixes more

* fixes boehmGC

* cover more cases

* fixes cyclic deps

* fixes genode

* cleanup

* unpublic fields

* cleanup

* clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ringabout @Araq