Unbundle drnim #207
Merged
Unbundle drnim #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haxscramper
force-pushed
the
unbundle-drnim
branch
4 times, most recently
from
f647a5f to
e79c703
Compare
- Removes main drnim directory along with all the hacks added into `sem*` implementation - special keywords for `ensures/requires/assume/invariant`, more logic built into sempass and so on. Sem reports that were added in the main compilation. - External tooling for code analysis should better be implemented via completely external modifications, instead of clobbering the main compiler codebase with logic for barely functioning tooling. With DOD refactor this task becomes much easier, since extra metadata can be attached to any symbol. - We definitely want to move in the direction of automatic code correctness and static analysis, but right now this is not a priority, and considering dubious implementation of the tool, it would be easier to remove it for now and come up with a proper implementation later on, or when can turn all hacks back into sem. - drnim itself not tested as a part of CI so right now it can't even be built, due to file reorganization nim-works#177. - Adds reports for `--staticBounds:on|off` that were mistakenly assumed to be drnim-only during earlier refactor nim-works#94 for structured reports. Closes nim-works#130 as this pull removes `drnim` as well, and the author of that PR is no longer responsive. Due to multiple merge conflicts it is highly unlikely the old PR will be revived.
haxscramper
force-pushed
the
unbundle-drnim
branch
from
e79c703 to
848b6b6
Compare
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sem*implementation - special keywords for
ensures/requires/assume/invariant, more logic built into sempass and soon. Sem reports that were added in the main compilation.
completely external modifications, instead of clobbering the main
compiler codebase with logic for barely functioning tooling. With DOD
refactor this task becomes much easier, since extra metadata can be
attached to any symbol.
and static analysis, but right now this is not a priority, and
considering dubious implementation of the tool, it would be easier to
remove it for now and come up with a proper implementation later on, or
when can turn all hacks back into sem.
file reorganization Sort compiler files into more manageable structure #177.
--staticBounds:on|offthat were mistakenly assumed tobe drnim-only during earlier refactor
Structured reports #94 for structured reports.
Closes #130 as this pull removes
drnimas well, and the author of that PR is no longer responsive. Due tomultiple merge conflicts it is highly unlikely the old PR will be revived.