Skip to content
This repository has been archived by the owner on Dec 11, 2018. It is now read-only.

Chat example for bullet #45

Closed
wants to merge 1 commit into from
Closed

Conversation

eldondev
Copy link

I am learning Erlang and have created a simple chat example for bullet. This should allow multiple browsers to navigate to a change and engange in a simple chat session. If you'd like me to make any impovements, I'm eager for feedback.
Thanks!

@essen
Copy link
Member

essen commented Sep 25, 2013

I'll look at it in a few days. Thanks!

@essen
Copy link
Member

essen commented Nov 18, 2013

Hello, now that Cowboy 0.9.0 is out this needs a small update to the static handler configuration. Can you do it? Also make sure there's only one commit in the PR. Thanks!

@eldondev
Copy link
Author

Sure, I will give it a shot some time this week.

@eldondev
Copy link
Author

Bump! Updated for 0.9.0 and merged into 1 commit.

@essen
Copy link
Member

essen commented Jan 6, 2014

I have fetched and confirmed that it works. I do not feel good enough to review the code precisely yet. I have a few general comments though.

  • When pressing enter the text doesn't get sent, you should bind the form submit rather than the button click
  • Don't do register(spawn(...)), add it to the supervision tree, and use a gen_server for that process, examples are expected to show good practice
  • You don't need to whereis(process_name) to send a message to it, Erlang understands process_name ! message
  • Whitespace is all messed up, please fix it, tabs for indentation and no alignment

@essen
Copy link
Member

essen commented Jun 3, 2014

Hi! Any news? Thanks.

@essen
Copy link
Member

essen commented Nov 13, 2015

Closing in favor of #66. Thanks!

@essen essen closed this Nov 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants