Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vpc_config change #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vpc_config change #6

wants to merge 1 commit into from

Conversation

babyhuey
Copy link

@babyhuey babyhuey commented Mar 1, 2022

Formatting and changing the vpc config to not be dynamic. There can only be one.

@babyhuey
Copy link
Author

pinging on this. Any chance of updating with this fix?

@babyhuey
Copy link
Author

babyhuey commented Jun 7, 2022

@punkrokk @ninthnails

@ninthnails
Copy link
Owner

Hi @babyhuey , thank you for the PR. The use of dynamic for the vpc config is there not because it support multiple values, but because the VPC for code build project is optional. The vpc_id and subnet_ids variables are both optional as well. Your changes will force using a VPC, but I would prefer retaining the support for no VPC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@babyhuey @ninthnails