Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Yaroslav Halchenko <[email protected]>
  • Loading branch information
bpinsard and yarikoptic authored Sep 29, 2024
1 parent 2aa4427 commit a934582
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions heudiconv/convert.py
Original file line number Diff line number Diff line change
Expand Up @@ -527,13 +527,12 @@ def update_multiorient_name(
metadata: dict[str, Any],
filename: str,
) -> str:
if "acq-" in filename:
if "_acq-" in filename:
lgr.warning(

Check warning on line 531 in heudiconv/convert.py

View check run for this annotation

Codecov / codecov/patch

heudiconv/convert.py#L531

Added line #L531 was not covered by tests
"Not embedding multi-orientation information as prefix already uses acq- parameter."
"Not embedding multi-orientation information as `%r` already uses acq- parameter.", filename
)
return filename

Check warning on line 534 in heudiconv/convert.py

View check run for this annotation

Codecov / codecov/patch

heudiconv/convert.py#L534

Added line #L534 was not covered by tests
iop = metadata.get("ImageOrientationPatientDICOM")
# iop = [round(x) for x in iop]
assert isinstance(iop, list)
cross_prod = [
iop[1] * iop[5] - iop[2] * iop[4],
Expand Down

0 comments on commit a934582

Please sign in to comment.