Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run modules before createUnimport #3016

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

huang-julien
Copy link
Contributor

πŸ”— Linked issue

fix #3015

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Hello πŸ‘‹

This PR fix modules autoimports not being typed. It just run modules before creating unimport.

This shouldn't cause any issue as nitro.unimport is typed as maybe undefined

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@huang-julien huang-julien requested a review from pi0 as a code owner January 21, 2025 22:23
@pi0 pi0 changed the title fix(core): run modules before createUnimport fix: run modules before createUnimport Jan 21, 2025
@pi0 pi0 merged commit 005a74f into nitrojs:v2 Jan 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modules cannot inject auto imports
2 participants