test: re-enable docker int

nixpig · Dec 15, 2024 · 98ed4ba · 98ed4ba
1 parent 1a08075
commit 98ed4ba
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -81,7 +81,7 @@ jobs:
           sudo systemctl restart docker
 
       # for some reason this hangs in CI; need to investigate
-      # - name: run docker hello-world
-      #   run: |
-      #     ./test/docker-integration.sh
+      - name: run docker hello-world
+        run: |
+          sudo ./test/docker-integration.sh
 
diff --git a/container/container_reexec.go b/container/container_reexec.go
@@ -148,6 +148,7 @@ func (c *Container) Reexec() error {
 		return fmt.Errorf("set additional GIDs: %w", err)
 	}
 
+	// TODO: reimplement uid and gid mappings for execve
 	// if c.Spec.Linux.UIDMappings != nil {
 	// 	cmd.SysProcAttr.UidMappings =
 	// 		user.BuildUIDMappings(c.Spec.Linux.UIDMappings)