forked from ribanez/Hilbert-AE
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development: A lot of refactoring and documentation. #2
Open
diegovalenzuelaiturra
wants to merge
128
commits into
master
Choose a base branch
from
development
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…methods process_file method now recives a callable mapper
…h process_file method in datasets
… renamed some arguments
updated documentation and type annotations, deleted useless comments, renamed some arguments
updated documentation and type annotations, deleted useless comments, renamed some arguments
added **kwargs, change Optional for Union for type hinitng,
…alidation error, and log model weights to tensorboard
…into development
…he other arguments weren't used
In case we want to use other loss, we should consider adding a sigmoid layer to the decoder output (or something alike)
diegovalenzuelaiturra
changed the title
Development:
Development: A lot of refactoring and documentation.
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HDF5 concurrent reads aren't safe.
h5py objects cannot be pickled.
We should aim to fix this behaviour in order to use multiple threads in Dataloaders. For now, I've fix
num_workers = 1
for Dataloaders.Added
config.json
file that contains most of the configuration parameters for runningtrain.py
Now using BCEWithLogitsLoss loss instead of MSE loss.
Added a HilbertMapper class.
Added train_step and validation_step methods to Autoencoder module, both are now used in the training script.
Added process_batch method to utils module.
Added encode and decode methods to general Autoencoder class.
Added set_configs method to utils, to configure device and seeds, etc.
Added save_checkpoint, load_from_checkpoint and create_folders methods.
Added Tensorboard writer, currently logging model parameters and training and validation losses.
Added Upsampling module in Encoder Input and Downsampling module in Decoder Output.
Added Reshape module to be used in conjunction with Sequential module.
Added a Meter and Accumulator Classes.
Added a get_train_dev_sets method to split the dataset.
Added some code to experiment with apex NVIDIA Mixed precision training to be used in GPUs that support this feature. The apex library should be pre-installed, more information about it can be found here: https://github.com/NVIDIA/apex
To create the dataset file, now run the export_dataset script. The build_dataloader_from_disk method now returns train and dev dataloaders.
Updated documentation.
Included type annotations.
Renamed some methods and arguments.
Deleted useless comments.
Some references are included in the Readme file.
Currently using tqdm progress bar.
Added some methods to be implemented in future.
Updated LICENSE.
Python Version:
Environment:
I'm using some linters:
And I'm also using a formatter: