Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear previous RagGrid renders #66

Closed
wants to merge 2 commits into from
Closed

Conversation

hollywoof
Copy link
Contributor

See #65

Purpose of change

  • FEATURE IMPLEMENTATION
  • CODE QUALITY IMPROVEMENT
  • BUG FIX

Description of change

Clear Html Element before adding a new grid

After accepting PR minimised grid js will need to be recreated

Version

Current

Reviewer

?

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2020

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #66   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           2       2           
  Lines          67      61    -6     
======================================
+ Misses         67      61    -6     
Impacted Files Coverage Δ
R/RagGrid.R 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 718f723...cbff353. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 5, 2020

Pull Request Test Coverage Report for Build 137

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 122: 0.0%
Covered Lines: 0
Relevant Lines: 61

💛 - Coveralls

@slodge slodge mentioned this pull request Jun 10, 2020
3 tasks
@hollywoof
Copy link
Contributor Author

Closing this request = #68 contains further and better fixes

@hollywoof hollywoof closed this Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants