Merge pull request #87 from josephmturner/fixes

Fixes
nobiot · Oct 25, 2024 · 9d6d389 · 9d6d389
2 parents 574f90d + bebef1b
commit 9d6d389
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 8 deletions.
diff --git a/org-remark-icon.el b/org-remark-icon.el
@@ -1,4 +1,4 @@
-;;; org-remark-icon.el --- Enable Org-roam to use icons -*- lexical-binding: t; -*-
+;;; org-remark-icon.el --- Enable Org-remark to use icons -*- lexical-binding: t; -*-
 
 ;; Copyright (C) 2021-2024 Free Software Foundation, Inc.
 
@@ -170,10 +170,7 @@ Each overlay is a highlight."
       (let ((icon-string
              ;; The third arg of `mapconcat' is not optional in Emacs 28 or lower.
              (mapconcat #'add-icon-maybe org-remark-icons nil)))
-        ;; `mapconcat' returns "" when all function calls for SEQUENCE
-        ;; return nil, I guess to guarantee the result is a string
-        (when (and icon-string
-                   (not (string= icon-string "")))
+        (when (< 0 (length icon-string))
           (org-remark-icon-overlay-put
            ov icon-string
            (overlay-get ov 'org-remark-type)))))))

diff --git a/org-remark-info.el b/org-remark-info.el
@@ -1,4 +1,4 @@
-;;; org-remark-info.el --- Support Org-roam with Info-mode -*- lexical-binding: t; -*-
+;;; org-remark-info.el --- Support Org-remark with Info-mode -*- lexical-binding: t; -*-
 
 ;; Copyright (C) 2021-2024 Free Software Foundation, Inc.
 

diff --git a/org-remark-line.el b/org-remark-line.el
@@ -1,4 +1,4 @@
-;;; org-remark-line.el --- Enable Org-roam to highlight a line -*- lexical-binding: t; -*-
+;;; org-remark-line.el --- Enable Org-remark to highlight a line -*- lexical-binding: t; -*-
 
 ;; Copyright (C) 2021-2024 Free Software Foundation, Inc.
 

diff --git a/org-remark.el b/org-remark.el
@@ -928,7 +928,7 @@ Put FACE and other necessary properties to the highlight OV"
 (cl-defmethod org-remark-highlight-make-overlay (beg end face
                                                      (_org-remark-type (eql nil)))
   "Make overlay BEG END and add FACE to it.
-If FACE is nil, this function uses defaul face `org-remark-highlighter'.
+If FACE is nil, this function uses default face `org-remark-highlighter'.
 This is a method for highlights of default ORG-REMARK-TYPE, that
 is for a character range."
   (let ((ov (make-overlay beg end nil :front-advance)))