fix: org-remark-info-mode interfering with isearch-forward #93 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With my light testing, I didn't find any regression, but I do not recall why I thought the `org-remark-info-highlights-load` was needed after `Info-search`. Please report if you encounter any regression.
Info-selection-hook gets triggered for both the cases that the original Info-find-node and Info-search advice functions were meant to cover.
|
Rebased main (commit 458ebe3) that includes this fix. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With my light testing, I didn't find any regression, but I do not recall why I thought the
org-remark-info-highlights-loadwas needed afterInfo-search. Please report if you encounter any regression.This is a quick band-aid patch for lack of my capacity (= time) at the moment. It needs more thorough investigation and testing -- help would be appreciated.