Various minor cleanup #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarsius
force-pushed
the
tidy
branch
2 times, most recently
from
853fba9 to
a0d7df2
Compare
|
Friendly ping! |
|
Oh! Thank you 🙏 I missed this! Let me have a look, probably on the weekend. Travelling for business now. |
Both message and user-error take a f-string as first argument.
Likewise use and-let* instead of when-let. This is preferable when the value of the form matters, as it communicates the fact that that is the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see commits for details. If you don't like a particular change, I can
drop it for you.