Switch ci-sdxl github runner and refactor workflow. #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if we update apt before installing cmake, perhaps this won't happen? or we can use the pip install. |
Yeah, we won't need CMake in integration test workflows once #584 is completed. The package build will be completed on one runner (either as workflow dependency or from a prior nightly build), then test runners will just pip install. Since this workflow is running on |
ScottTodd
changed the title
|
Successful run of the workflow (phew, no regressions!): https://github.com/nod-ai/shark-ai/actions/runs/12166327005/job/33932314986?pr=644 |
saienduri
approved these changes
Dec 4, 2024
monorimet
pushed a commit
that referenced
this pull request
Dec 13, 2024
The `mi300-sdxl-kernel` runner has been offline for a few weeks, so runs of this workflow have been queued: https://github.com/nod-ai/shark-ai/actions/workflows/ci-sdxl.yaml. This `mi300x-4` runner is probably fit to run this workflow. Also refactored the workflow to not use explicit build steps, which loosens the requirements on installed software and helps make progress on #584.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mi300-sdxl-kernelrunner has been offline for a few weeks, so runs of this workflow have been queued: https://github.com/nod-ai/shark-ai/actions/workflows/ci-sdxl.yaml. Thismi300x-4runner is probably fit to run this workflow.Also refactored the workflow to not use explicit build steps, which loosens the requirements on installed software and helps make progress on #584.