lowjs 20200402+1028ffb (binaries only) #592
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinging @neoniousTR as maintainer of lowjs...
This adds a binaries-only definition file for lowjs. Subsequent PRs will start to add the ability to compile lowjs from source.
Questions for Thomas Rogg:
This build is named
20200402+1028ffb
but based on the sha, it looks like it's actuallyv1.4.9
. Is this correct? Should this be published within nodenv asv1.4.9
or20200402+1028ffb
? Which version naming scheme will be used moving forward. Is it expected that binary dists are typically only published for tagged releases? If so, will these binaries eventually be uploaded as assets with each GitHub Release?(I'm concerned about consistent releases since it looks like the last release tag of v1.4.9 is at sha 93cc895 but the binary is from sha 1028ffb.)
I see that the tarball doesn't contain a bin named 'node'. Is it common for lowjs users to want their
low
bin to be symlinked asnode
? For a similar example, in ruby-build, the jruby definition symlinksjruby
asruby
. So when a jruby is activated, invokingruby
gives one the jruby runtime. Similarly in nodenv, graalvm's definition symlinks node to its graalvm node runtime. Alternatively, is it frequently necessary for "standard" node to still be available alongside lowjs such that symlinking lowjs as node is specifically undesirable?Does npm work for lowjs or is there a package manager that should be bundled with low or installed automatically when lowjs is installed by nodenv? Can node packages be installed "globally" under lowjs'
lib/node_modules
directory similar to npm installing packages under nodejs'lib/node_modules
directory?Anything else that would be useful for lowjs builds? I'd like to eventually get source compilation definitions added for lowjs, so nodenv can be used to compile releases and nightlies in addition to downloading binary dists.
Thanks! Hopefully nodenv can provide some helpful utility to lowjs users!
#457