Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bucket notifications - fix TopicConfiguration array for get (github issue 8647) #8655

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

alphaprinz
Copy link
Contributor

Explain the changes

  1. The TopicConfiguration array was not being converted to proper xml when bucket has more than one notification confs.

Issues: Fixed #xxx / Gap #xxx

  1. Multi level connections are not supported  #8647

Testing Instructions:

  1. Add several bucket notifications to a bucket.
  2. Perform get bucket notification s3op on bucket.
  • Doc added/updated
  • Tests added

Copy link
Contributor

@aspandey aspandey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alphaprinz alphaprinz merged commit fa24e9b into noobaa:master Jan 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants