Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bucket notifications - go on to next event when checking event filters (gh issue 8652) #8659

Merged
merged 1 commit into from
Jan 7, 2025
+1 −1
Merged

bucket notifications - go on to next event when checking event filters (gh issue 8652) #8659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/util/notifications_util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ function check_notif_relevant(notif, req) {
const notif_event_elems = notif_event.split(':');
const notif_event_name = notif_event_elems[1];
const notif_event_method = notif_event_elems[2];
if (notif_event_name.toLowerCase() !== op_event.name.toLowerCase()) return false;
if (notif_event_name.toLowerCase() !== op_event.name.toLowerCase()) continue;
//is there filter by method?
if (notif_event_method === '*') {
//no filtering on method. we've passed the filter and need to send a notification
Expand Down
Loading