Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

add-service-port-nginx #661

Merged
merged 1 commit into from
Nov 14, 2023
Merged

add-service-port-nginx #661

merged 1 commit into from
Nov 14, 2023

Conversation

aprilrieger
Copy link
Contributor

adds the service port to nginx, once it's enabled the hyrax chart expects those values to be set in the values file

Story

Deploy on main fails after adding the nginx service to the values file for the production deployment. Adding the service port to the values file under the nginx service will elleviate the error and have the deployment back on track in no time!

Expected Behavior Before Changes

Expected Behavior After Changes

Screenshots / Video

Notes

…ects those values to be set in the values file
Copy link
Contributor

@orangewolf orangewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also need serviceType?

@aprilrieger
Copy link
Contributor Author

aprilrieger commented Nov 14, 2023

@orangewolf no just the port unless service.port is already defined in the values file, https://github.com/samvera/hyrax/blob/72619eaf57765419031d46ac6c83d099fa0c1b15/chart/hyrax/templates/ingress.yaml#L3C1-L3C1

{{- if .Values.ingress.enabled -}}
{{- $svcFullName := ternary (include "hyrax.nginx.host" .) (include "hyrax.fullname" .) .Values.nginx.enabled -}}
{{- $svcPort := ternary .Values.nginx.service.port .Values.service.port .Values.nginx.enabled -}}

@aprilrieger aprilrieger merged commit 838d9fa into main Nov 14, 2023
@jeremyf jeremyf deleted the add-service-port-nginx branch December 1, 2023 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants