This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
Update IiifPrint to fix PDF splitting #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laritakr
changed the title
Pulls in a fix to find the PDF file needed for creating child works.
jeremyf
approved these changes
Nov 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
This pulls in a fix for iiif_print PDF splitting.
Refs:
Expected Behavior Before Changes
Expected Behavior After Changes
When a PDF is attached to a work, the child works are successfully created.
PDF splitting is expected to complete normally, whether via a standard Bulkrax import, an import using files from SpaceStone, or a UI import.
See sample test via this OAI import: https://adl.s2.adventistdigitallibrary.org/importers/108?locale=e
Screenshots / Video
Notes