Zero energy deposited by track ends in vacuum. #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There has been a long-standing bug in DOSXYZnrc where the code will tend to segmentation fault if you use the "surrounding material" as VACUUM (the default). I wonder if the fixes you suggest will also fix that! |
|
That would be nice, @rtownson! But I don't know. Do these segmentation faults occur during or at the end of the runs? |
|
I think it was during, but I'll have to find a case that reproduces this. |
rtownson
approved these changes
Aug 19, 2024
mainegra
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle "rare" cases of energy deposited (edep) in vacuum due to tracks ending once particles cross into the region by immediately zeroing edep. Requires a fix to dosxyznrc to handle the case of 0/0=NAN causing a crash. May also require fixes to other user codes to handle similar NAN cases.
Fixes #1061