chore(repo): wip

docs/generated/devkit/Task.md

@@ -31,7 +31,7 @@ Determines if a given task should be cacheable.
 
 ### continuous
 
-• **continuous**: `boolean`
+• `Optional` **continuous**: `boolean`
 
 This denotes if the task runs continuously
 

packages/nx/src/config/task-graph.ts

@@ -85,7 +85,7 @@ export interface Task {
   /**
    * This denotes if the task runs continuously
    */
-  continuous: boolean;
+  continuous?: boolean;
 }
 
 /**

packages/nx/src/tasks-runner/forked-process-task-runner.ts

@@ -216,6 +216,7 @@ export class ForkedProcessTaskRunner {
     task: Task,
     {
       streamOutput,
+      temporaryOutputPath,
       taskGraph,
       env,
     }: {
@@ -250,8 +251,17 @@ export class ForkedProcessTaskRunner {
       });
       this.processes.add(cp);
 
-      cp.onExit(() => {
+      cp.onExit((code, terminalOutput) => {
         this.processes.delete(cp);
+
+        if (!streamOutput) {
+          this.options.lifeCycle.printTaskTerminalOutput(
+            task,
+            code === 0 ? 'success' : 'failure',
+            terminalOutput
+          );
+        }
+        this.writeTerminalOutput(temporaryOutputPath, terminalOutput);
       });
 
       return cp;
@@ -284,9 +294,7 @@ export class ForkedProcessTaskRunner {
         stdio: ['inherit', 'inherit', 'inherit', 'ipc'],
         env,
       });
-      const cp = new NodeChildProcessWithDirectOutput(p, {
-        temporaryOutputPath,
-      });
+      const cp = new NodeChildProcessWithDirectOutput(p, temporaryOutputPath);
 
       this.processes.add(cp);
 
@@ -300,10 +308,10 @@ export class ForkedProcessTaskRunner {
 
       cp.onExit((code, signal) => {
         this.processes.delete(cp);
-        const terminalOutput = cp.getTerminalOutput();
         // we didn't print any output as we were running the command
         // print all the collected output
         try {
+          const terminalOutput = cp.getTerminalOutput();
           if (!streamOutput) {
             this.options.lifeCycle.printTaskTerminalOutput(
               task,

packages/nx/src/tasks-runner/running-tasks/node-child-process.ts

@@ -8,7 +8,8 @@ import { readFileSync } from 'fs';
 export class NodeChildProcessWithNonDirectOutput implements RunningTask {
   private terminalOutput: string;
   private exitCode: number;
-  private exitCallbacks: Array<(code: number) => void> = [];
+  private exitCallbacks: Array<(code: number, terminalOutput: string) => void> =
+    [];
 
   constructor(
     private childProcess: ChildProcess,
@@ -39,7 +40,7 @@ export class NodeChildProcessWithNonDirectOutput implements RunningTask {
 
     this.onExit(() => {
       for (const cb of this.exitCallbacks) {
-        cb(this.exitCode);
+        cb(this.exitCode, this.terminalOutput);
       }
     });
 
@@ -58,7 +59,7 @@ export class NodeChildProcessWithNonDirectOutput implements RunningTask {
     });
   }
 
-  onExit(cb: (code: number) => void) {
+  onExit(cb: (code: number, terminalOutput: string) => void) {
     this.exitCallbacks.push(cb);
   }
 
@@ -155,15 +156,15 @@ function logClearLineToPrefixTransformer(prefix: string) {
 }
 
 export class NodeChildProcessWithDirectOutput implements RunningTask {
-  private terminalOutput = '';
+  private terminalOutput: string | undefined;
   private exitCallbacks: Array<(code: number, signal: string) => void> = [];
 
   private exited = false;
   private exitCode: number;
 
   constructor(
     private childProcess: ChildProcess,
-    { temporaryOutputPath }: { temporaryOutputPath: string }
+    private temporaryOutputPath: string
   ) {
     // Re-emit any messages from the task process
     this.childProcess.on('message', (message) => {
@@ -182,10 +183,6 @@ export class NodeChildProcessWithDirectOutput implements RunningTask {
         cb(code, signal);
       }
     });
-
-    this.onExit(() => {
-      this.terminalOutput = readFileSync(temporaryOutputPath).toString();
-    });
   }
 
   send(message: Serializable): void {
@@ -199,16 +196,17 @@ export class NodeChildProcessWithDirectOutput implements RunningTask {
   }
 
   async getResults(): Promise<{ code: number; terminalOutput: string }> {
+    const terminalOutput = this.getTerminalOutput();
     if (this.exited) {
       return Promise.resolve({
         code: this.exitCode,
-        terminalOutput: this.terminalOutput,
+        terminalOutput,
       });
     }
     await this.waitForExit();
     return Promise.resolve({
       code: this.exitCode,
-      terminalOutput: this.terminalOutput,
+      terminalOutput,
     });
   }
 
@@ -219,6 +217,7 @@ export class NodeChildProcessWithDirectOutput implements RunningTask {
   }
 
   getTerminalOutput() {
+    this.terminalOutput ??= readFileSync(this.temporaryOutputPath).toString();
     return this.terminalOutput;
   }