-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript project references article #29698
base: master
Are you sure you want to change the base?
Typescript project references article #29698
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
View your CI Pipeline Execution ↗ for commit ce574ef.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments
|
||
![results](/blog/images/2025-01-21/results.png) | ||
|
||
In addition to the time savings we saw reduced memory usage (~< 1GB vs 3 GB). This makes sense given what we saw about how project references work. This is actually a very good thing for CI pipelines, as exceeding memory usuage is a common issue we see with our clients for their TypeScript builds. Less memory usuage means we can use smaller machines, which saves on the CI costs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should emphasize the "performance" part more and where this comes from. it is kinda mentioned, but maybe we can emphasize it better 🤔. Like the "breaking down TS programs" into smaller units, the incremental nature of it, the fact that there are tsconfig.tsbuildinfo
files generated which tsc -b
uses to avoid recomputation of types etc, thus being incremental etc :)
Will there be a migration for this? If so, maybe do point it out in this article, so people won't start to try and migrate to new project references on their own. Also I saw somewhere that it won't work for Angular for now? Is that the case? If so maybe also add note about it here. |
We're looking into that. For now it's behind a flag There's a series of articles coming out, this one specifically just talks about project references
It doesn't work for Angular. That's not on the Nx side, but on the Angular side. We're looking into it though. |
https://nx-dev-git-fork-zackderose-typescript-project-refer-8c9adb-nrwl.vercel.app/blog/typescript-project-references