fix(rspack): should be inferred by default #29736
Open
+281
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 2d5e551.
☁️ Nx Cloud last updated this comment at |
ndcunningham
force-pushed
the
fix/rspack-inferred-by-default
branch
from
22048db to
2d5e551
Compare
Coly010
reviewed
Jan 24, 2025
Comment on lines
-28
to
-53
| export async function setupRspackConfiguration( | ||
| tree: Tree, | ||
| options: NormalizedSchema<Schema>, | ||
| tasks: any[] | ||
| ) { | ||
| const { configurationGenerator } = ensurePackage('@nx/rspack', nxVersion); | ||
| const rspackTask = await configurationGenerator(tree, { | ||
| project: options.projectName, | ||
| main: joinPathFragments( | ||
| options.appProjectRoot, | ||
| maybeJs( | ||
| { | ||
| js: options.js, | ||
| useJsx: true, | ||
| }, | ||
| `src/main.tsx` | ||
| ) | ||
| ), | ||
| tsConfig: joinPathFragments(options.appProjectRoot, 'tsconfig.app.json'), | ||
| target: 'web', | ||
| newProject: true, | ||
| framework: 'react', | ||
| }); | ||
| tasks.push(rspackTask); | ||
| } | ||
|
|
There was a problem hiding this comment.
If someone decides they dont want crystal - or their workspace already has useInferencePlugins: false what would happen with this missing?
There was a problem hiding this comment.
It will behave the same as Webpack. This should be working unless I missed something during my tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Rspack Plugin to be inferred by default.
Currently
When you generate a project using rspack it would not be inferred and would add the executor to
project.json.After
Generating a project using rspack will add it to inferred plugins inside
nx.jsonand update therspack.config.jsto be a standard config and use Nx plugins.