Skip to content

Commit

Permalink
Stop upload master-release to Play Console to avoid versionCode error.
Browse files Browse the repository at this point in the history
  • Loading branch information
seanwu1105 committed Oct 15, 2020
1 parent 52badcf commit 3a9996a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 29 deletions.
28 changes: 1 addition & 27 deletions .github/workflows/qa-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ jobs:
*APKs*
<https://drive.google.com/drive/folders/1NHQH1Xi47GXNy1_afNvRDrcUxiuLRl6E?usp=sharing|Google Drive (Master-Debug, Master-QA, Internal-Debug and Internal-QA)>
<https://play.google.com/apps/internaltest/MODIFY_LATER|Google Play Internal Testing (Master-Release)>
<https://play.google.com/apps/testing/io.numbersprotocol.numberscapture|Google Play Closed Alpha Testing (Internal-Release)>
*Notes*
Expand All @@ -127,12 +126,6 @@ jobs:
with:
java-version: 1.8

- name: Test and build master-release bundle (AAB)
if: steps.extract_branch.outputs.branch == 'numbers'
run: |
./gradlew testMasterRelease
./gradlew bundleMasterRelease
- name: Test and build internal-release bundle (AAB)
if: steps.extract_branch.outputs.branch == 'numbers'
env:
Expand All @@ -141,16 +134,6 @@ jobs:
./gradlew testInternalRelease
./gradlew bundleInternalRelease
- name: Sign master-release AAB
if: steps.extract_branch.outputs.branch == 'numbers'
uses: r0adkll/sign-android-release@v1
with:
releaseDirectory: ./app/build/outputs/bundle/masterRelease
signingKeyBase64: ${{ secrets.KEYSTORE_FILE }}
alias: ${{ secrets.KEY_ALIAS }}
keyStorePassword: ${{ secrets.KEYSTORE_PASSWORD }}
keyPassword: ${{ secrets.KEY_PASSWORD }}

- name: Sign internal-release AAB
if: steps.extract_branch.outputs.branch == 'numbers'
uses: r0adkll/sign-android-release@v1
Expand All @@ -165,16 +148,7 @@ jobs:
if: steps.extract_branch.outputs.branch == 'numbers'
run: echo '${{ secrets.SERVICE_ACCOUNT_JSON }}' > service_account.json

- name: Deploy to Play Store (internal)
if: steps.extract_branch.outputs.branch == 'numbers'
uses: r0adkll/upload-google-play@v1
with:
serviceAccountJson: service_account.json
packageName: io.numbersprotocol.numberscapture
releaseFile: ./app/build/outputs/bundle/masterRelease/app-master-release.aab
track: internal

- name: Deploy to Play Store (alpha)
- name: Deploy to Play Store (closed alpha track)
if: steps.extract_branch.outputs.branch == 'numbers'
uses: r0adkll/upload-google-play@v1
with:
Expand Down
4 changes: 2 additions & 2 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ android {
applicationId "io.numbersprotocol.numberscapture"
minSdkVersion 26
targetSdkVersion 30
versionCode 7
versionName "1.7.0-numbers"
versionCode 2
versionName "1.7.0-numbers-rc1"

testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"

Expand Down

0 comments on commit 3a9996a

Please sign in to comment.